feat: emoji autocomplete in the edit custom status modal#40926
feat: emoji autocomplete in the edit custom status modal#40926ricardogarim wants to merge 45 commits into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
56ffc82 to
718e76a
Compare
3b25380 to
99020c3
Compare
c6dde89 to
acfffeb
Compare
Co-authored-by: ricardogarim <ricardogarim@users.noreply.github.com>
d252671 to
b054ffc
Compare
b054ffc to
5d07308
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/presence-expiration-ui #40926 +/- ##
===============================================================
+ Coverage 70.12% 70.24% +0.12%
===============================================================
Files 3357 3373 +16
Lines 129552 130695 +1143
Branches 22407 22674 +267
===============================================================
+ Hits 90843 91810 +967
- Misses 35416 35567 +151
- Partials 3293 3318 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5d07308 to
d93460d
Compare
a98223d to
5bea13b
Compare
Proposed changes (including videos or screenshots)
Adds
EmojiTextInput, a plain text input wired to the shared autocomplete engine through thefromInputElementadapter, and uses it for the status-message field inEditStatusModal— giving emoji:autocomplete in the edit custom status modal.Issue(s)
PRES-30
Steps to test or reproduce
Open the user menu → edit status. Type
hello :rocin the status field → the emoji popup appears; selecting inserts:rocket:. Arrow/Enter/Esc and click selection all work; popup closes on blur.Further comments
Carries the engine commits (move + decouple) on top of
feat/presence-expiration-uiso the engine is available; those also appear in #41050 / #40925 againstdevelopand collapse once the engine PRs merge. First planned consumer of the shared engine.